In the App.java from main source set there is the static method App.getApp() from which
many parts of the application get ApplicationContext. But as the class App inherits from
BraveApp and sets the app variable in onCreate() only after the super.onCreate()
from BraveApp is called. Therefore App.getApp() has not yet an initialized variable
thus we need another way to get the ApplicationContext
As the custom TrustManagerFactory was only set correctly in BraveOkHttpTlsHelper
but not if setting the default SSLSocketFactory for HttpsURLConnection.
So the whole code for adding own CA's was moved into BraveTrustManagerFactoryHelper
and the BraveTLSSocketFactory handles now its usage internally and not via
constructor.
As workaround internally we use GZIP to reduce the amount of data that
is put as in intent.putExtra(). It has to be tested if that compressing
takes to much time and truncate here already.
As later on if we share on the ErrorActivity we have to truncate the traces
to around 100Kb as it otherwise crash there.
- Hotfix for wrong okhttp-urlconnection dependency on non Kitkat version.
Thank you @marcel263 for reporting
- BraveNewPipe Settings page:
config option to circumvent some censoring
https://github.com/bravenewpipe/NewPipeExtractor/issues/122
- Use cookie on rumble.com stream page to tackle redirect glitch
https://github.com/bravenewpipe/NewPipeExtractor/issues/123
- Kitkat flavor: This is only a test. I could not really test it on hardware.
Therefore it will not migrate any data from previous installs. It installs
in parallel to any BraveNewPipe installation. This will change if I get feedback
that it is working more or less properly.
All problems please enter in https://github.com/bravenewpipe/NewPipeExtractor/issues/124
and if it is too big create a extra bug entry.
This patch copies all the relevant files for Kitkat from main to the legacy flavor unmodified.
The relevant files are gathered from commit 189c92affa
'More minSdk 21 cleanup'
These files are the base to reapply above 'More minSdk 21 cleanup' commit
in reverse in a later patch.
This patch copies all the relevant files for kitkat from main to the legacy flavor unmodified.
The relevant files are gathered from commit 99104fc11d
'Clean up pre-Lollipop checks'
These files are the base to reapply above 'Clean up pre-Lollipop checks' commit
in reverse in a later patch.
DownloaderImpl:
- add: reInitInterceptors() method to recreate in case of config changes
BraveDownloaderImplUtils:
- add: BraveTimeoutInterceptor that handles the custom timeout via temporary http header.
- OkHttpClient is now instantiated right away. This should be the only instance
within the app.
- All OkHttpClient.Builder instances should be retrieved via
DownloaderImpl.getNewBuilder() which delegates the call to
OkHttpClient.newBuilder() So we are not recreating the whole ConnectionPool etc.
SponsorBlock/ReturnYouTubeDislike created a new OkHttpClient each call if
setCustomTimeout() was set once. This commit restores DownloaderImpl back.
-> the calls to setCustomTimeout() will be replaced with a custom http header
solution
- update RUMBLE/BITCHUTE to new Tab-Framework
- RUMBLE: most issues should be fixed#119
- BITCHUTE: Broken: Trending -> account is now needed -> CANTFIX
- BITCHUTE: Broken: import of many subscriptions will fail due to use of reCatchpa
-> may implement a workaround - if I've some time
