From 44acea2f5d7eb633bd20fa94ef48384b7a8c3178 Mon Sep 17 00:00:00 2001 From: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Date: Tue, 4 Jan 2022 06:22:49 +0800 Subject: [PATCH] Add content to the contributing guidelines --- .github/CONTRIBUTING.md | 37 ++++++++++++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 162cb5f..389502c 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -1,15 +1,42 @@ # How to Contribute -I want to thank you for sparing time to improve this project! Here are some guidelines for contributingļ¼š +We want to thank you for sparing time to improve this project! Here are some guidelines for contributingļ¼š -To ensure that the blog design is not confused, this project does not accept suggestions for design changes, such as color scheme, fonts, typography, etc. If your request is about an enhancement, it is recommended to first submit a [`Feature Request`](https://github.com/cotes2020/jekyll-theme-chirpy/issues/new?labels=enhancement&template=feature_request.md) issue to discuss whether your idea fits the project. +To ensure that the blog design is not confused, this project does not accept suggestions for design changes, such as color scheme, fonts, typography, etc. If your request is about an enhancement, it is recommended to first submit a [_Feature Request_](https://github.com/cotes2020/jekyll-theme-chirpy/issues/new?labels=enhancement&template=feature_request.md) issue to discuss whether your idea fits the project. + +## Basic Process Generally, contribute to the project by: 1. Fork this project on GitHub and clone it locally. -2. Create a new branch from `master` and give it a descriptive name (e.g., `my-new-feature`, `fix-a-bug`). -3. After completing the development, commit and push to remote. -4. Submit a new pull request. +2. Create a new branch from the default branch and give it a descriptive name (e.g., `my-new-feature`, `fix-a-bug`). +3. After completing the development, submit a new _Pull Request_. + +## Modifying JavaScript + +If your contribution involves JS modification, please read the following sections. + +### Inline Scripts + +If you need to add comments to the inline JS (the JS code between the tags ``), please use `/**/` instead of two slashes `//`. Because the HTML will be compressed by [jekyll-compress-html](https://github.com/penibelst/jekyll-compress-html) during deployment, but it cannot handle the `//` properly. And this will disrupt the structure of the compressed HTML. + +### External Scripts + +If you need to add or modify JavaScripts in the directory `_javascript`, you need to install [Gulp.js](https://gulpjs.com/docs/en/getting-started/quick-start). + +During development, real-time debugging can be performed through the following commands: + +```console +$ bash tools/run.sh +``` + +Open another terminal tab and run: + +```console +$ gulp dev # Type 'Ctrl + C' to stop +``` + +After debugging, run the command `gulp` (without any argument) will automatically output the compressed files to the directory `assests/js/dist/`. ---