diff --git a/app/build.gradle b/app/build.gradle index b903eafca..4b6890eac 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -186,7 +186,7 @@ dependencies { // name and the commit hash with the commit hash of the (pushed) commit you want to test // This works thanks to JitPack: https://jitpack.io/ implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751' - implementation 'com.github.TeamNewPipe:NewPipeExtractor:v0.21.6' + implementation 'com.github.TeamNewPipe:NewPipeExtractor:c38a06e8dcd9c206a52b622704b138b78d633274' /** Checkstyle **/ checkstyle "com.puppycrawl.tools:checkstyle:${checkstyleVersion}" diff --git a/app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java index 5d2cc4fdf..3d11e90c0 100644 --- a/app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java +++ b/app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java @@ -6,6 +6,7 @@ import android.view.Menu; import android.view.MenuInflater; import android.view.View; import android.view.ViewGroup; +import android.widget.TextView; import androidx.annotation.NonNull; import androidx.annotation.Nullable; @@ -24,6 +25,8 @@ import io.reactivex.rxjava3.disposables.CompositeDisposable; public class CommentsFragment extends BaseListInfoFragment { private final CompositeDisposable disposables = new CompositeDisposable(); + private TextView emptyStateDesc; + public static CommentsFragment getInstance(final int serviceId, final String url, final String name) { final CommentsFragment instance = new CommentsFragment(); @@ -35,6 +38,13 @@ public class CommentsFragment extends BaseListInfoFragment { super(UserAction.REQUESTED_COMMENTS); } + @Override + protected void initViews(final View rootView, final Bundle savedInstanceState) { + super.initViews(rootView, savedInstanceState); + + emptyStateDesc = rootView.findViewById(R.id.empty_state_desc); + } + /*////////////////////////////////////////////////////////////////////////// // LifeCycle //////////////////////////////////////////////////////////////////////////*/ @@ -73,6 +83,12 @@ public class CommentsFragment extends BaseListInfoFragment { @Override public void handleResult(@NonNull final CommentsInfo result) { super.handleResult(result); + + emptyStateDesc.setText( + result.isCommentsDisabled() + ? R.string.comments_are_disabled + : R.string.no_comments); + ViewUtils.slideUp(requireView(), 120, 150, 0.06f); disposables.clear(); } diff --git a/app/src/main/res/layout/fragment_comments.xml b/app/src/main/res/layout/fragment_comments.xml index 3c9a1785f..b8e536c73 100644 --- a/app/src/main/res/layout/fragment_comments.xml +++ b/app/src/main/res/layout/fragment_comments.xml @@ -41,6 +41,7 @@ tools:ignore="HardcodedText,UnusedAttribute" /> Ausschalten, um Kommentare auszublenden Automatische Wiedergabe Keine Kommentare + Kommentare sind deaktiviert Kommentare konnten nicht geladen werden Schließen Wiedergabe fortsetzen diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index acef587d1..f75380101 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -336,6 +336,7 @@ %s videos No comments + Comments are disabled Start Pause