ErrorActivity: Use a proper zoned ISO timestamp

Will have a timezone offset and be parsable as valid ISO8601
timestamp.

Also change the label in the UI to just say “Timestamp”
This commit is contained in:
Nikunj-Aggarwal 2025-01-08 00:14:35 +05:30 committed by Profpatsch
parent f7d0fd545d
commit 65749cbac0
2 changed files with 5 additions and 7 deletions

View file

@ -26,7 +26,7 @@ import org.schabi.newpipe.util.Localization;
import org.schabi.newpipe.util.ThemeHelper; import org.schabi.newpipe.util.ThemeHelper;
import org.schabi.newpipe.util.external_communication.ShareUtils; import org.schabi.newpipe.util.external_communication.ShareUtils;
import java.time.LocalDateTime; import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter; import java.time.format.DateTimeFormatter;
import java.util.Arrays; import java.util.Arrays;
import java.util.stream.Collectors; import java.util.stream.Collectors;
@ -67,10 +67,6 @@ public class ErrorActivity extends AppCompatActivity {
public static final String ERROR_GITHUB_ISSUE_URL = public static final String ERROR_GITHUB_ISSUE_URL =
"https://github.com/TeamNewPipe/NewPipe/issues"; "https://github.com/TeamNewPipe/NewPipe/issues";
public static final DateTimeFormatter CURRENT_TIMESTAMP_FORMATTER =
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm");
private ErrorInfo errorInfo; private ErrorInfo errorInfo;
private String currentTimeStamp; private String currentTimeStamp;
@ -107,7 +103,9 @@ public class ErrorActivity extends AppCompatActivity {
// important add guru meditation // important add guru meditation
addGuruMeditation(); addGuruMeditation();
currentTimeStamp = CURRENT_TIMESTAMP_FORMATTER.format(LocalDateTime.now()); // print current time, as zoned ISO8601 timestamp
final ZonedDateTime now = ZonedDateTime.now();
currentTimeStamp = now.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME);
activityErrorBinding.errorReportEmailButton.setOnClickListener(v -> activityErrorBinding.errorReportEmailButton.setOnClickListener(v ->
openPrivacyPolicyDialog(this, "EMAIL")); openPrivacyPolicyDialog(this, "EMAIL"));

View file

@ -266,7 +266,7 @@
<string name="error_snackbar_action">Report</string> <string name="error_snackbar_action">Report</string>
<string name="what_device_headline">Info:</string> <string name="what_device_headline">Info:</string>
<string name="what_happened_headline">What happened:</string> <string name="what_happened_headline">What happened:</string>
<string name="info_labels">What:\\nRequest:\\nContent Language:\\nContent Country:\\nApp Language:\\nService:\\nGMT Time:\\nPackage:\\nVersion:\\nOS version:</string> <string name="info_labels">What:\\nRequest:\\nContent Language:\\nContent Country:\\nApp Language:\\nService:\\nTimestamp:\\nPackage:\\nVersion:\\nOS version:</string>
<string name="your_comment">Your comment (in English):</string> <string name="your_comment">Your comment (in English):</string>
<string name="error_details_headline">Details:</string> <string name="error_details_headline">Details:</string>
<!-- Content descriptions (for better accessibility) --> <!-- Content descriptions (for better accessibility) -->