From 4bfd2b0bd50c05ded810458a85dca6b33d70ad17 Mon Sep 17 00:00:00 2001 From: polymorphicshade Date: Sun, 23 Aug 2020 15:17:09 -0600 Subject: [PATCH] SponsorBlock: Made some strings translatable I forgot to make these translatable... --- .../java/org/schabi/newpipe/player/VideoPlayerImpl.java | 6 ++++-- .../schabi/newpipe/settings/ContentSettingsFragment.java | 3 ++- .../schabi/newpipe/settings/custom/EditColorPreference.java | 2 +- app/src/main/res/values/strings.xml | 4 ++++ 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java b/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java index 7a69ba3d0..50e5ce629 100644 --- a/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java +++ b/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java @@ -666,10 +666,12 @@ public class VideoPlayerImpl extends VideoPlayer switch (getSponsorBlockMode()) { case DISABLED: - Toast.makeText(context, "SponsorBlock disabled", Toast.LENGTH_SHORT).show(); + Toast.makeText(context, R.string.sponsor_block_disabled_toast, Toast.LENGTH_SHORT) + .show(); break; case ENABLED: - Toast.makeText(context, "SponsorBlock enabled", Toast.LENGTH_SHORT).show(); + Toast.makeText(context, R.string.sponsor_block_enabled_toast, Toast.LENGTH_SHORT) + .show(); break; case EXCLUDE: // ignored diff --git a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java index dd2bfef01..1ae3cb92d 100644 --- a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java +++ b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java @@ -180,7 +180,8 @@ public class ContentSettingsFragment extends BasePreferenceFragment { .putStringSet( getString(R.string.sponsor_block_exclusion_list_key), new HashSet<>()) .apply(); - Toast.makeText(getContext(), "Exclusion list cleared", Toast.LENGTH_SHORT).show(); + Toast.makeText(getContext(), R.string.sponsor_block_exclusion_list_cleared_toast, + Toast.LENGTH_SHORT).show(); return true; }); } diff --git a/app/src/main/java/org/schabi/newpipe/settings/custom/EditColorPreference.java b/app/src/main/java/org/schabi/newpipe/settings/custom/EditColorPreference.java index 23b2b11a4..22464c2b2 100644 --- a/app/src/main/java/org/schabi/newpipe/settings/custom/EditColorPreference.java +++ b/app/src/main/java/org/schabi/newpipe/settings/custom/EditColorPreference.java @@ -74,7 +74,7 @@ public class EditColorPreference extends EditTextPreference return true; } catch (final Exception e) { - Toast.makeText(getContext(), "Invalid color", Toast.LENGTH_SHORT).show(); + Toast.makeText(getContext(), R.string.invalid_color_toast, Toast.LENGTH_SHORT).show(); return false; } } diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 573efbaec..7d43117d6 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -252,6 +252,7 @@ Restore defaults Do you want to restore defaults? Give permission to display over other apps + Invalid color Sorry, that should not have happened. Guru Meditation. @@ -708,4 +709,7 @@ Toggle skipping sponsors Clear Exclusion List Clear the list of uploaders excluded from SponsorBlock. + SponsorBlock enabled + SponsorBlock disabled + Exclusion list cleared